Network security groups for TRE core subnets#784
Merged
Conversation
…k-security-groups
…k-security-groups
Unit Test Results 1 files ±0 1 suites ±0 3m 18s ⏱️ ±0s For more details on these failures, see this check. Results for commit 419ee4a. ± Comparison against base commit 419ee4a. ♻️ This comment has been updated with latest results. |
…k-security-groups
…k-security-groups
…k-security-groups
3 tasks
Closed
Closed
TessFerrandez
approved these changes
Sep 9, 2021
Member
|
LGTM, two minor text nits, take them or leave them! |
Co-authored-by: Tess Ferrandez <tferrand@microsoft.com>
Co-authored-by: Tess Ferrandez <tferrand@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for issue #67
Introduces and documents network security groups and their security rules for TRE core subnets.